merlimat commented on a change in pull request #10878:
URL: https://github.com/apache/pulsar/pull/10878#discussion_r648880330
##########
File path:
tests/docker-images/java-test-functions/src/main/java/org/apache/pulsar/tests/integration/io/TestGenericObjectSink.java
##########
@@ -56,10 +56,11 @@ public void write(Record<GenericObject> record) {
if (record.getSchema().getSchemaInfo().getType() ==
SchemaType.KEY_VALUE) {
// assert that we are able to access the schema (leads to
ClassCastException if there is a problem)
- KeyValueSchema kvSchema = (KeyValueSchema) record.getSchema();
- log.info("key schema type {}", kvSchema.getKeySchema());
- log.info("value schema type {}", kvSchema.getValueSchema());
- log.info("key encoding {}", kvSchema.getKeyValueEncodingType());
+ // TODO need to expose KeyValueSchema was an interface in
pulsar-client-api
+// KeyValueSchema kvSchema = (KeyValueSchema) record.getSchema();
Review comment:
It's not a breaking change because `KeyValueSchema` is not part of
public API. Only symbols that are in `pulsar-client-api` are. I think the test
here should use `Schema<KeyValue>` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
