[GitHub] [pulsar-client-go] dferstay commented on a change in pull request #535: Fix data race while accessing connection in partitionConsumer

[GitBox]

dferstay commented on a change in pull request #535:
URL: https://github.com/apache/pulsar-client-go/pull/535#discussion_r649526755



##########
File path: pulsar/consumer_partition.go
##########
@@ -971,9 +972,9 @@ func (pc *partitionConsumer) grabConn() error {
                pc.name = res.Response.ConsumerStatsResponse.GetConsumerName()
        }
 
-       pc.conn = res.Cnx
+       pc._setConn(res.Cnx)
        pc.log.Info("Connected consumer")
-       pc.conn.AddConsumeHandler(pc.consumerID, pc)
+       pc._getConn().AddConsumeHandler(pc.consumerID, pc)

Review comment:
       @cckellogg ,
   I'm thinking that since [PR 
376](https://github.com/apache/pulsar-client-go/pull/376) drains the connection 
incomingRequestsCh on close it should be possible remove the extra go-routine 
in the partitionConsumer and select from the connectionClosedCh in the 
partitonConsumer.runEventsLoop.  What do you think?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org