jerrypeng commented on a change in pull request #10878:
URL: https://github.com/apache/pulsar/pull/10878#discussion_r650078541



##########
File path: 
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -179,7 +179,6 @@ public void start() throws Exception {
                 String.format("%s-%s",
                         
FunctionCommon.getFullyQualifiedName(instanceConfig.getFunctionDetails()),
                         instanceConfig.getInstanceId()));
-        this.fnThread.setContextClassLoader(functionClassLoader);

Review comment:
       When we start JavaInstanceRunnable, the context classloader needs to be 
set to instanceClassLoader, which is done by default, because the 
instanceClassLoader contains all the classes for the function instance / 
framework.  The functionClassLoader only contains classes that were submitted 
by the user via a JAR or a NAR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to