[GitHub] [pulsar] massakam commented on a change in pull request #10762: [broker] Fix issue that message ordering could be broken when redelivering messages on Key_Shared subscription

[GitBox]

massakam commented on a change in pull request #10762:
URL: https://github.com/apache/pulsar/pull/10762#discussion_r652294994



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
##########
@@ -142,6 +142,14 @@ public synchronized void removeConsumer(Consumer consumer) 
throws BrokerServiceE
                 }
             };
 
+    private static final FastThreadLocal<Map<Consumer, Set<Integer>>> 
localConsumerStickyKeyHashesMap =

Review comment:
       No, I don't have clear evidence. I just implemented it the same as the 
existing `localGroupedEntries`.
   
https://github.com/apache/pulsar/blob/40c831761a7519e4ce9f0b7b8808cdb6df3f418e/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java#L143-L149
   
   `localGroupedEntries` seems to have been added in the following PR:
   https://github.com/apache/pulsar/pull/7104
   
   @merlimat, do we need to use ThreadLocal in this case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org