Anonymitaet commented on a change in pull request #10961:
URL: https://github.com/apache/pulsar/pull/10961#discussion_r655150896
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
return shutdownService;
}
+ public static String advertisedAddress(ServiceConfiguration config) {
Review comment:
@lhotari thanks for the suggestion
Since @315157973 is the developer of this and can provide technically
correct explanations, would you like to add descriptions in javadoc? Then I
would like to review, thanks
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1360,10 +1360,13 @@ public ShutdownService getShutdownService() {
return shutdownService;
}
+ public static String advertisedAddress(ServiceConfiguration config) {
Review comment:
@315157973 pls ping me if you need doc review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
