hsaputra commented on a change in pull request #10657: URL: https://github.com/apache/pulsar/pull/10657#discussion_r655770029
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java ########## @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.resourcegroup; + +import static org.apache.pulsar.broker.cache.ConfigurationCacheService.RESOURCEGROUPS; +import static org.apache.pulsar.common.policies.path.PolicyPath.path; +import com.google.common.collect.Sets; +import java.util.HashSet; +import java.util.Set; +import java.util.function.Consumer; +import org.apache.pulsar.broker.PulsarService; +import org.apache.pulsar.broker.resources.ResourceGroupResources; +import org.apache.pulsar.client.admin.PulsarAdminException; +import org.apache.pulsar.common.policies.data.ResourceGroup; +import org.apache.pulsar.metadata.api.Notification; +import org.apache.pulsar.metadata.api.NotificationType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ResourceGroupConfigListener implements Consumer<Notification> { Review comment: HI @bharanic-dev - could you add JavaDoc summery for this class to explain "why" it is created and description of its primary function and maybe relationship with other parts of the code. ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java ########## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.resourcegroup; + +import static org.apache.pulsar.broker.admin.ZkAdminPaths.POLICIES; +import static org.apache.pulsar.common.policies.path.PolicyPath.path; +import java.util.function.Consumer; +import org.apache.pulsar.broker.PulsarService; +import org.apache.pulsar.broker.resources.NamespaceResources; +import org.apache.pulsar.broker.resources.TenantResources; +import org.apache.pulsar.client.admin.PulsarAdminException; +import org.apache.pulsar.common.policies.data.Policies; +import org.apache.pulsar.metadata.api.Notification; +import org.apache.pulsar.metadata.api.NotificationType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ResourceGroupNamespaceConfigListener implements Consumer<Notification> { Review comment: Similar for this class. Would be nice to have Java doc header explanation on why this class is created and description of its main functions and relations with other parts of the code. ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java ########## @@ -128,7 +130,7 @@ public ResourceGroup(ResourceGroup other) { } } - protected void updateResourceGroup(ResourceGroupConfigInfo rgConfig) { + protected void updateResourceGroup(org.apache.pulsar.common.policies.data.ResourceGroup rgConfig) { Review comment: Why change to include the full package name here? ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java ########## @@ -0,0 +1,162 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.resourcegroup; + +import static org.apache.pulsar.broker.admin.ZkAdminPaths.POLICIES; +import static org.apache.pulsar.common.policies.path.PolicyPath.path; +import java.util.function.Consumer; +import org.apache.pulsar.broker.PulsarService; +import org.apache.pulsar.broker.resources.NamespaceResources; +import org.apache.pulsar.broker.resources.TenantResources; +import org.apache.pulsar.client.admin.PulsarAdminException; +import org.apache.pulsar.common.policies.data.Policies; +import org.apache.pulsar.metadata.api.Notification; +import org.apache.pulsar.metadata.api.NotificationType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class ResourceGroupNamespaceConfigListener implements Consumer<Notification> { Review comment: Similar for this class. Would be better to have Java doc header explanation on why this class is created and description of its main functions and relations with other parts of the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
