freeznet commented on a change in pull request #548:
URL: https://github.com/apache/pulsar-client-go/pull/548#discussion_r656110752
##########
File path: pulsar/internal/http_client.go
##########
@@ -52,7 +52,7 @@ func (c *httpClient) Close() {
}
type HTTPClient interface {
- Get(endpoint string, obj interface{}) error
+ Get(endpoint string, obj interface{}, params map[string]string) error
Review comment:
> Is this change related to the certificate updates
it is related to Pulsar 2.8.0, seems the `GetPartitionedTopicMetadata` with
http lookup service has to pass `checkAllowAutoCreation=true` as params to get
the partition num of the non-existed topic. So once we run CI with Pulsar
2.8.0, the tests will fail. [related with
https://github.com/apache/pulsar/pull/10601]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
