lhotari commented on a change in pull request #11033:
URL: https://github.com/apache/pulsar/pull/11033#discussion_r656829539
##########
File path:
pulsar-io/flume/src/test/java/org/apache/pulsar/io/flume/node/TestEnvVarResolverProperties.java
##########
@@ -18,52 +18,51 @@
*/
package org.apache.pulsar.io.flume.node;
-import java.io.File;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
import org.junit.contrib.java.lang.system.EnvironmentVariables;
+import org.testng.Assert;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import java.io.File;
public final class TestEnvVarResolverProperties {
private static final File TESTFILE = new File(
TestEnvVarResolverProperties.class.getClassLoader()
.getResource("flume-conf-with-envvars.properties").getFile());
- @Rule
public final EnvironmentVariables environmentVariables = new
EnvironmentVariables();
Review comment:
The `org.junit.contrib.java.lang.system.EnvironmentVariables` class
depends on the usage of Junit. The usage of EnvironmentVariables class should
be adapted if junit is removed from this class and replaced with TestNG. Please
address this aspect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
