wuchenxi123 edited a comment on pull request #11112: URL: https://github.com/apache/pulsar/pull/11112#issuecomment-869162324
>Could you explain why did you swallow the exception in close() while fail fast in setup()? For your case, preProcess should not throw a checked exception. > >In addition, IMO it's not a good practice to just use Exception as the checked exception but not the subclass of Exception. > Could you explain why did you swallow the exception in `close()` while fail fast in `setup()`? For your case, `preProcess` should not throw a checked exception. > > In addition, IMO it's not a good practice to just use `Exception` as the checked exception but not the subclass of `Exception`. Accept your suggestion, I have corrected your problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
