GPrabhudas commented on a change in pull request #555: URL: https://github.com/apache/pulsar-client-go/pull/555#discussion_r660231758
########## File path: pulsar/crypto/message_metadata.go ########## @@ -0,0 +1,122 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package crypto + +import ( + pb "github.com/apache/pulsar-client-go/pulsar/internal/pulsar_proto" +) + +// MessageMetadataSupplier wrapper implementation around message metadata +type MessageMetadataSupplier interface { Review comment: Goal : Is to provide client(user) to set/read the required information in/from `MessageMetadata`. Meaningful name => I think it is meaningful since it just providing a way to read some info from internal `MessageMetadata` `MessageMetadata` => this is from the `proto` which is an internal package and client can not access it directly and this class implemented required methods to read/write MessageMetadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
