BewareMyPower opened a new pull request #11152:
URL: https://github.com/apache/pulsar/pull/11152


   ### Motivation
   
   Visual Studio 2017 cannot compile the code of latest master
   
   
![image](https://user-images.githubusercontent.com/18204803/123817671-ed6b0600-d92a-11eb-8616-cbdc3778cf7b.png)
   
   It's introduced from https://github.com/apache/pulsar/pull/11088. For some 
compilers, `std::max` might be included implicitly, but C++ standard only 
requires that it's included in `<algorithm>` header, see 
https://en.cppreference.com/w/cpp/algorithm/max for reference.
   
   ### Modifications
   
   Include `<algorithm>` header for `std::max` function.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to