Technoboy- commented on a change in pull request #11085:
URL: https://github.com/apache/pulsar/pull/11085#discussion_r661203380
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
##########
@@ -133,5 +142,24 @@ public ClientConfigurationData clone() {
}
}
+ public InetSocketAddress getSocks5ProxyAddress() {
+ if (Objects.nonNull(socks5ProxyAddress)) {
+ return socks5ProxyAddress;
+ }
+ String proxyAddress = System.getProperty("socks5Proxy.address");
Review comment:
Yes, this is not a common feature, @codelipenghui suggest to support
from System property. But keep the clientBuilder together. We maybe remove the
client builder api somedays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
