eolivelli commented on a change in pull request #11150:
URL: https://github.com/apache/pulsar/pull/11150#discussion_r661216170
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##########
@@ -319,7 +323,7 @@ private String getDynamicConfigurationFromStore(String
path, String settingName,
private double getDynamicConfigurationDouble(String path, String
settingName, double defaultValue) {
double result = defaultValue;
try {
- String setting = this.getDynamicConfigurationFromStore(path,
settingName, null);
+ String setting = this.getDynamicConfigurationFromStore(path,
settingName, String.valueOf(defaultValue));
Review comment:
what is the impact of this change ?
we should add unit tests around this method and
`getDynamicConfigurationBoolean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
