wangjialing218 commented on pull request #10973: URL: https://github.com/apache/pulsar/pull/10973#issuecomment-880341416
> Can you add an integration test? https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/ElasticSearchSinkTester.java @tuteng `ElasticSearchSinkTester` use `ElasticSearchContainer` to preform test. The container is one node es, it seems not possible to perfrom multi nodes test there. I have add the test in `ElasticSearchSinkTests`, and made `ElasticSearchSink.getClient` from private to protected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
