jerrypeng commented on a change in pull request #11343:
URL: https://github.com/apache/pulsar/pull/11343#discussion_r671434885
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java
##########
@@ -136,27 +146,27 @@ private static void makeFile(final InputStream
inputStream, final File file) thr
}
/**
- * Calculates an md5 sum of the specified file.
+ * Calculates an sha256 sum of the specified file.
*
* @param file
- * to calculate the md5sum of
- * @return the md5sum bytes
+ * to calculate the sha256 of
+ * @return the sha256 bytes
* @throws IOException
* if cannot read file
*/
- private static byte[] calculateMd5sum(final File file) throws IOException {
+ private static byte[] calculateSha256Sum(final File file) throws
IOException {
Review comment:
What is the reason we need to change to SHA-256?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
