[GitHub] [pulsar] congbobo184 commented on a change in pull request #11304: [Transaction] Fix transaction buffer client handle endTxn op when topic or sub have been deleted.

[GitBox]

congbobo184 commented on a change in pull request #11304:
URL: https://github.com/apache/pulsar/pull/11304#discussion_r684581277



##########
File path: 
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java
##########
@@ -311,10 +232,32 @@ public void testTransactionBufferChannelUnActive() {
     }
 
     @Test
-    public void testTransactionBufferLookUp() throws ExecutionException, 
InterruptedException {
+    public void testTransactionBufferLookUp() throws Exception {
         String topic = "persistent://" + namespace + 
"/testTransactionBufferLookUp";
-        tbClient.abortTxnOnSubscription(topic + "_abort_sub", "test", 1L, 1L, 
-1L).get();
-        tbClient.commitTxnOnSubscription(topic + "_commit_sub", "test", 1L, 
1L, -1L).get();
+        String subName = "test";
+        admin.topics().createNonPartitionedTopic(topic + "_abort_sub");
+        admin.topics().createSubscription(topic + "_abort_sub", subName, 
MessageId.earliest);
+
+        admin.topics().createNonPartitionedTopic(topic + "_commit_sub");
+        admin.topics().createSubscription(topic + "_commit_sub", subName, 
MessageId.earliest);
+
+        Awaitility.await().until(() -> {

Review comment:
       adopt your comment, thank for your comments. please review again




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org