wuzhanpeng commented on a change in pull request #11606:
URL: https://github.com/apache/pulsar/pull/11606#discussion_r685787550
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -372,6 +374,21 @@ public String getReplicatorPrefix() {
String id = TopicName.get(base).getSchemaName();
SchemaRegistryService schemaRegistryService =
brokerService.pulsar().getSchemaRegistryService();
return schemaRegistryService.getSchema(id)
+ .exceptionally(t -> {
+ if (t.getCause() != null
Review comment:
Thank you for your reply!
For question 1, the condition is inspired by
`SchemaRegistryServiceImpl#trimDeletedSchemaAndGetList(java.lang.String)`, that
is, those schemas with unrecoverable exceptions would be regarded as deleted
schemas. Therefore here I continue to use the design concept.
For question 2, I agree that unrecoverable SchemaException is not equivant
to "Schema does not exist". However in schema storage deletion scenario, an
unrecoverable exception, which includes `NoSuchLedgerException` and
`NoSuchEntryException`, is enough to say that the schema has already been
deleted by others and we can quit the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
