jerrypeng commented on a change in pull request #11627:
URL: https://github.com/apache/pulsar/pull/11627#discussion_r688081880
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -883,16 +887,21 @@ private void sendFlowPermitsToBroker(ClientCnx cnx, int
numMessages) {
public void connectionFailed(PulsarClientException exception) {
boolean nonRetriableError =
!PulsarClientException.isRetriableError(exception);
boolean timeout = System.currentTimeMillis() > subscribeTimeout;
- if ((nonRetriableError || timeout) &&
subscribeFuture.completeExceptionally(exception)) {
- setState(State.Failed);
- if (nonRetriableError) {
- log.info("[{}] Consumer creation failed for consumer {} with
unretriableError {}", topic, consumerId, exception);
- } else {
- log.info("[{}] Consumer creation failed for consumer {} after
timeout", topic, consumerId);
+ if (nonRetriableError || timeout) {
+ exception.setPreviousExceptions(previousExceptions);
+ if (subscribeFuture.completeExceptionally(exception)) {
+ setState(State.Failed);
+ if (nonRetriableError) {
+ log.info("[{}] Consumer creation failed for consumer {}
with unretriableError {}", topic, consumerId, exception);
+ } else {
+ log.info("[{}] Consumer creation failed for consumer {}
after timeout", topic, consumerId);
Review comment:
Can we add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
