eolivelli commented on a change in pull request #3823: URL: https://github.com/apache/pulsar/pull/3823#discussion_r690220029
########## File path: pulsar-io/alluxio/pom.xml ########## @@ -0,0 +1,161 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>pulsar-io</artifactId> + <groupId>org.apache.pulsar</groupId> + <version>2.9.0-SNAPSHOT</version> + </parent> + + <properties> + <alluxio.version>1.8.1</alluxio.version> + <jetty.version>9.2.16.v20160414</jetty.version> + </properties> + + <artifactId>pulsar-io-alluxio</artifactId> + <name>Pulsar IO :: Alluxio</name> + + <dependencies> + <dependency> + <groupId>${project.parent.groupId}</groupId> + <artifactId>pulsar-io-core</artifactId> + <version>${project.parent.version}</version> + </dependency> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>pulsar-functions-instance</artifactId> + <version>${project.version}</version> Review comment: is this really needed ? or do you need it only for tests? can you move the scope to "test" ? ########## File path: pulsar-io/alluxio/src/main/java/org/apache/pulsar/io/alluxio/sink/AlluxioSink.java ########## @@ -0,0 +1,284 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.alluxio.sink; + +import alluxio.AlluxioURI; +import alluxio.Configuration; +import alluxio.PropertyKey; +import alluxio.client.WriteType; +import alluxio.client.file.FileOutStream; +import alluxio.client.file.FileSystem; +import alluxio.client.file.options.CreateFileOptions; +import alluxio.exception.AlluxioException; +import com.google.common.collect.Lists; +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.client.api.schema.GenericObject; +import org.apache.pulsar.functions.api.Record; +import org.apache.pulsar.io.core.KeyValue; +import org.apache.pulsar.io.core.Sink; +import org.apache.pulsar.io.core.SinkContext; +import org.apache.pulsar.io.core.annotations.Connector; +import org.apache.pulsar.io.core.annotations.IOType; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.ObjectOutputStream; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import java.util.List; +import java.util.Map; +import java.util.UUID; + +/** + * Alluxio sink that treats incoming messages on the input topic as Strings + * and write identical key/value pairs. + */ +@Connector( + name = "alluxio", + type = IOType.SINK, + help = "The sink connector is used for moving records from Pulsar to Alluxio.", + configClass = AlluxioSinkConfig.class) +@Slf4j +public class AlluxioSink implements Sink<GenericObject> { + + private FileSystem fileSystem; + private FileOutStream fileOutStream; + private CreateFileOptions createFileOptions; + private long recordsNum; + private String tmpFilePath; + private String fileDirPath; + private String tmpFileDirPath; + private long lastRotationTime; + private long rotationRecordsNum; + private long rotationInterval; + private AlluxioSinkConfig alluxioSinkConfig; + private AlluxioState alluxioState; + + private List<Record<GenericObject>> recordsToAck; + + @Override + public void open(Map<String, Object> config, SinkContext sinkContext) throws Exception { + alluxioSinkConfig = AlluxioSinkConfig.load(config); + alluxioSinkConfig.validate(); + + // initialize FileSystem + String alluxioMasterHost = alluxioSinkConfig.getAlluxioMasterHost(); + int alluxioMasterPort = alluxioSinkConfig.getAlluxioMasterPort(); + Configuration.set(PropertyKey.MASTER_HOSTNAME, alluxioMasterHost); + Configuration.set(PropertyKey.MASTER_RPC_PORT, alluxioMasterPort); + if (alluxioSinkConfig.getSecurityLoginUser() != null) { + Configuration.set(PropertyKey.SECURITY_LOGIN_USERNAME, alluxioSinkConfig.getSecurityLoginUser()); + } + fileSystem = FileSystem.Factory.get(); + + // initialize alluxio dirs + String alluxioDir = alluxioSinkConfig.getAlluxioDir(); + fileDirPath = alluxioDir.startsWith("/") ? alluxioDir : "/" + alluxioDir; + tmpFileDirPath = fileDirPath + "/tmp"; + + AlluxioURI alluxioDirPath = new AlluxioURI(fileDirPath); + if (!fileSystem.exists(alluxioDirPath)) { + fileSystem.createDirectory(alluxioDirPath); + } + + AlluxioURI tmpAlluxioDirPath = new AlluxioURI(tmpFileDirPath); + if (!fileSystem.exists(tmpAlluxioDirPath)) { + fileSystem.createDirectory(tmpAlluxioDirPath); + } + + createFileOptions = CreateFileOptions.defaults(); + + recordsNum = 0; + recordsToAck = Lists.newArrayList(); + tmpFilePath = ""; + alluxioState = AlluxioState.WRITE_STARTED; + + lastRotationTime = System.currentTimeMillis(); + rotationRecordsNum = alluxioSinkConfig.getRotationRecords(); + rotationInterval = alluxioSinkConfig.getRotationInterval(); + } + + @Override + public void write(Record<GenericObject> record) { + long now = System.currentTimeMillis(); + + switch (alluxioState) { + case WRITE_STARTED: + try { + writeToAlluxio(record); + if (!shouldRotate(now)) { + break; + } + alluxioState = AlluxioState.FILE_ROTATED; + } catch (AlluxioException | IOException e) { + log.error("Unable to write record to alluxio.", e); + record.fail(); + break; + } + case FILE_ROTATED: + try { + closeAndCommitTmpFile(); + alluxioState = AlluxioState.FILE_COMMITTED; + ackRecords(); + } catch (AlluxioException | IOException e) { + log.error("Unable to flush records to alluxio.", e); + failRecords(); + try { + deleteTmpFile(); + } catch (AlluxioException | IOException e1) { + log.error("Failed to delete tmp cache file.", e); + } + break; + } + case FILE_COMMITTED: + alluxioState = AlluxioState.WRITE_STARTED; + break; + default: + log.error("{} is not a valid state when writing record to alluxio temp dir {}.", + alluxioState, tmpFileDirPath); + break; + } + } + + @Override + public void close() throws Exception { + // flush records in the tmpFile when closing sink + try { + closeAndCommitTmpFile(); + ackRecords(); + } catch (AlluxioException | IOException e) { + log.error("Unable to flush records to alluxio.", e); + failRecords(); + } + deleteTmpFile(); + } + + private void ackRecords() { + recordsToAck.forEach(Record::ack); + recordsToAck.clear(); + } + + private void failRecords() { + recordsToAck.forEach(Record::fail); + recordsToAck.clear(); + } + + private void writeToAlluxio(Record<GenericObject> record) throws AlluxioException, IOException { + KeyValue<String, String> keyValue = extractKeyValue(record); + if (fileOutStream == null) { + createTmpFile(); + } + fileOutStream.write(toBytes(keyValue.getValue())); + if (alluxioSinkConfig.getLineSeparator() != '\u0000') { + fileOutStream.write(alluxioSinkConfig.getLineSeparator()); + } + recordsNum++; + recordsToAck.add(record); + } + + private void createTmpFile() throws AlluxioException, IOException { + UUID id = UUID.randomUUID(); + String fileExtension = alluxioSinkConfig.getFileExtension(); + tmpFilePath = tmpFileDirPath + "/" + id.toString() + "_tmp" + fileExtension; + if (alluxioSinkConfig.getWriteType() != null) { + WriteType writeType; + try { + writeType = WriteType.valueOf(alluxioSinkConfig.getWriteType().toUpperCase()); + } catch (IllegalArgumentException e) { + throw new IllegalArgumentException("Illegal write type when creating Alluxio files, valid values are: " + + Arrays.asList(WriteType.values())); + } + createFileOptions.setWriteType(writeType); + } + fileOutStream = fileSystem.createFile(new AlluxioURI(tmpFilePath), createFileOptions); + } + + private void closeAndCommitTmpFile() throws AlluxioException, IOException { + // close the tmpFile + if (fileOutStream != null) { + fileOutStream.close(); + } + // commit the tmpFile + String filePrefix = alluxioSinkConfig.getFilePrefix(); + String fileExtension = alluxioSinkConfig.getFileExtension(); + String newFile = filePrefix + "-" + System.currentTimeMillis() + fileExtension; + String newFilePath = fileDirPath + "/" + newFile; + fileSystem.rename(new AlluxioURI(tmpFilePath), new AlluxioURI(newFilePath)); + fileOutStream = null; + tmpFilePath = ""; + recordsNum = 0; + lastRotationTime = System.currentTimeMillis(); + } + + private void deleteTmpFile() throws AlluxioException, IOException { + if (!tmpFilePath.equals("")) { + fileSystem.delete(new AlluxioURI(tmpFilePath)); + } + } + + private boolean shouldRotate(long now) { + boolean rotated = false; + if (recordsNum >= rotationRecordsNum) { + rotated = true; + } else { + if (rotationInterval != -1 && (now - lastRotationTime) >= rotationInterval) { + rotated = true; + } + } + return rotated; + } + + private static byte[] toByteArray(Object obj) throws IOException { + byte[] bytes = null; + try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); + ObjectOutputStream oos = new ObjectOutputStream(baos)) { + oos.writeObject(obj); + oos.flush(); + bytes = baos.toByteArray(); + } catch (IOException e) { + log.error("Failed to serialize the object.", e); + throw e; + } + return bytes; + } + + private static byte[] toBytes(Object obj) throws IOException { + byte[] bytes; + if (obj instanceof String) { + String s = (String) obj; + bytes = s.getBytes(StandardCharsets.UTF_8); + } else if (obj instanceof byte[]) { + bytes = (byte[]) obj; + } else { + bytes = toByteArray(obj); + } + return bytes; + } + + public KeyValue<String, String> extractKeyValue(Record<GenericObject> record) { + String key = record.getKey().orElseGet(() -> String.valueOf(record.getValue())); Review comment: record.getValue() is a GenericObject, that basically is a wrapper over a primitive value + schema information so here you have to use `record.getValue().getNativeObject()` it will be a `String`, a `byte[ ]`, another primitive type or even a `KeyValue` object if the topic is configured with a KeyValue schema. if you use the record.getValue().toString() you will not get an useful result (it will be the toString of the GenericObject wrapper) you can use record.getValue().getSchemaType() to inspect the schema type if you prefer. ########## File path: pulsar-io/alluxio/pom.xml ########## @@ -0,0 +1,161 @@ +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>pulsar-io</artifactId> + <groupId>org.apache.pulsar</groupId> + <version>2.9.0-SNAPSHOT</version> + </parent> + + <properties> + <alluxio.version>1.8.1</alluxio.version> + <jetty.version>9.2.16.v20160414</jetty.version> + </properties> + + <artifactId>pulsar-io-alluxio</artifactId> + <name>Pulsar IO :: Alluxio</name> + + <dependencies> + <dependency> + <groupId>${project.parent.groupId}</groupId> + <artifactId>pulsar-io-core</artifactId> + <version>${project.parent.version}</version> + </dependency> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>pulsar-functions-instance</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>pulsar-client-original</artifactId> + <version>${project.version}</version> Review comment: is this really needed ? or do you need it only for tests? can you move the scope to "test" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
