lhotari commented on pull request #11697: URL: https://github.com/apache/pulsar/pull/11697#issuecomment-901002619
> @lhotari which kind of test are you requiring ? a unit test that verifies that the GB -> bytes calculation works as expected. > > I am not sure it is worth to add the needed instrumentation to test this change. > The rounding error is quite evident I feel that it's important to test that the calculation is correct since #11671 changed the way how the limit is configured. We cannot rely that the result is correct unless we have a test in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
