merlimat commented on a change in pull request #11762:
URL: https://github.com/apache/pulsar/pull/11762#discussion_r695360127
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -129,7 +129,7 @@ ClientImpl::ClientImpl(const std::string& serviceUrl, const
ClientConfiguration&
}
}
-ClientImpl::~ClientImpl() { shutdown(); }
Review comment:
That would be a breaking change in the semantic. Right now the
destructor is taking care of automatically releasing all the resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
