[GitHub] [pulsar] Technoboy- commented on a change in pull request #11739: Expose compaction metrics to Prometheus

[GitBox]

Technoboy- commented on a change in pull request #11739:
URL: https://github.com/apache/pulsar/pull/11739#discussion_r697781074



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java
##########
@@ -242,24 +238,11 @@ protected void populateMaxMap(Map<String, Long> map, 
String mkey, long value) {
      */
     protected void populateDimensionMap(Map<Metrics, List<ManagedLedgerImpl>> 
ledgersByDimensionMap, Metrics metrics,
             ManagedLedgerImpl ledger) {
-        if (!ledgersByDimensionMap.containsKey(metrics)) {
-            // create new list
-            ledgersByDimensionMap.put(metrics, Lists.newArrayList(ledger));
-        } else {
-            // add to collection
-            ledgersByDimensionMap.get(metrics).add(ledger);
-        }
+        ledgersByDimensionMap.computeIfAbsent(metrics, __ -> 
Lists.newArrayList(ledger)).add(ledger);
     }
 
     protected void populateDimensionMap(Map<Metrics, List<TopicStats>> 
topicsStatsByDimensionMap,
             Metrics metrics, TopicStats destStats) {
-        if (!topicsStatsByDimensionMap.containsKey(metrics)) {
-            // create new list
-            topicsStatsByDimensionMap.put(metrics, 
Lists.newArrayList(destStats));
-        } else {
-            // add to collection
-            topicsStatsByDimensionMap.get(metrics).add(destStats);
-        }
-
+        topicsStatsByDimensionMap.computeIfAbsent(metrics, __ -> 
Lists.newArrayList(destStats)).add(destStats);

Review comment:
       Done.

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/CompactionMetrics.java
##########
@@ -159,10 +161,6 @@ public CompactionMetrics(PulsarService pulsar) {
     }
 
     private void populateDimensionMap(Map<Metrics, List<String>> 
topicsByDimensionMap, Metrics metrics, String topic) {
-        if (!topicsByDimensionMap.containsKey(metrics)) {
-            topicsByDimensionMap.put(metrics, Lists.newArrayList(topic));
-        } else {
-            topicsByDimensionMap.get(metrics).add(topic);
-        }
+        topicsByDimensionMap.computeIfAbsent(metrics, __ -> 
Lists.newArrayList(topic)).add(topic);

Review comment:
       Yes, thanks. 

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java
##########
@@ -242,24 +238,11 @@ protected void populateMaxMap(Map<String, Long> map, 
String mkey, long value) {
      */
     protected void populateDimensionMap(Map<Metrics, List<ManagedLedgerImpl>> 
ledgersByDimensionMap, Metrics metrics,
             ManagedLedgerImpl ledger) {
-        if (!ledgersByDimensionMap.containsKey(metrics)) {
-            // create new list
-            ledgersByDimensionMap.put(metrics, Lists.newArrayList(ledger));
-        } else {
-            // add to collection
-            ledgersByDimensionMap.get(metrics).add(ledger);
-        }
+        ledgersByDimensionMap.computeIfAbsent(metrics, __ -> 
Lists.newArrayList(ledger)).add(ledger);

Review comment:
       Done

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/AbstractMetrics.java
##########
@@ -214,11 +214,7 @@ protected Metrics createMetricsByDimension(String 
namespace, String fromClusterN
     }
 
     protected void populateAggregationMap(Map<String, List<Double>> map, 
String mkey, double value) {
-        if (!map.containsKey(mkey)) {
-            map.put(mkey, Lists.newArrayList(value));
-        } else {
-            map.get(mkey).add(value);
-        }
+        map.computeIfAbsent(mkey, __ -> Lists.newArrayList(value)).add(value);

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org