EronWright opened a new pull request #12066: URL: https://github.com/apache/pulsar/pull/12066
Master Issue: #12040 ### Motivation It should be possible to use the `advertisedListeners` configuration property in Pulsar standalone mode. One reason is to support dev scenarios involving multiple listeners. Another is to make standalone mode more consistent, e.g. to avoid special cases like seen [here](https://github.com/streamnative/rop/commit/3e59300628704e296f9a97870c7250ff616747ef). ### Modifications - Fix `NoopLoadManager` to actually advertise the configured advertised listeners. - Don't always force the 'proxy mode' in the lookup response; check that the `advertisedAddress` is `localhost`. - Initialize the internal admin client to use the actual advertised address. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - Anything that affects deployment: yes ### Documentation Check the box below and label this PR (if you have committer privilege). Need to update docs? - [ ] no-need-doc This PR addresses an undocumented limitation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
