gaozhangmin commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712182761
##########
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##########
@@ -137,9 +167,12 @@ public void testBasic() throws Exception {
Set<BookieId> bookieToExclude = new HashSet<>();
bookieToExclude.add(new BookieSocketAddress(BOOKIE1).toBookieId());
- ensemble = isolationPolicy.newEnsemble(2, 2, 2,
Collections.emptyMap(), bookieToExclude).getResult();
- assertTrue(ensemble.contains(new
BookieSocketAddress(BOOKIE4).toBookieId()));
- assertTrue(ensemble.contains(new
BookieSocketAddress(BOOKIE2).toBookieId()));
+ try {
Review comment:
for the previous, the `BOOKIE4` was not included into any region, so
it's good for including BOOKIE4 in ensemble.
But now, we will add `BOOKIE4` to blacklistedBookies, so it will throw
error because only BOOKIE2 available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
