codelipenghui commented on a change in pull request #12349:
URL: https://github.com/apache/pulsar/pull/12349#discussion_r728136041
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2379,10 +2379,15 @@ protected void
internalSetSchemaCompatibilityStrategy(SchemaCompatibilityStrateg
"schemaCompatibilityStrategy");
}
- protected boolean internalGetSchemaValidationEnforced() {
+ protected boolean internalGetSchemaValidationEnforced(boolean applied) {
validateNamespacePolicyOperation(namespaceName,
PolicyName.SCHEMA_COMPATIBILITY_STRATEGY,
PolicyOperation.READ);
- return getNamespacePolicies(namespaceName).schema_validation_enforced;
+ boolean schemaValidationEnforced =
getNamespacePolicies(namespaceName).schema_validation_enforced;
+ if (!schemaValidationEnforced && applied) {
+ return pulsar().getConfiguration().isSchemaValidationEnforced();
Review comment:
If the broker level is true and the namespace level is false, we will
apply false right? not the broker level configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
