[GitHub] [pulsar] codelipenghui commented on a change in pull request #12523: add a metric to get earliest time in the backlog

[GitBox]

codelipenghui commented on a change in pull request #12523:
URL: https://github.com/apache/pulsar/pull/12523#discussion_r743622687



##########
File path: 
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -856,8 +858,13 @@ default void delete(String topic, boolean force) throws 
PulsarAdminException {
      * @throws PulsarAdminException
      *             Unexpected error
      */
-    TopicStats getStats(String topic, boolean getPreciseBacklog,
-                        boolean subscriptionBacklogSize) throws 
PulsarAdminException;
+    TopicStats getStats(String topic, boolean getPreciseBacklog, boolean 
subscriptionBacklogSize,

Review comment:
       No, all of the getStats methods is a public API, users might be used in 
their application, if we change one of them, users will encounter compatibility 
issues. 
   
   ```java
       TopicStats getStats(String topic, boolean getPreciseBacklog,
                           boolean subscriptionBacklogSize) throws 
PulsarAdminException;
   
       default TopicStats getStats(String topic, boolean getPreciseBacklog) 
throws PulsarAdminException {
           return getStats(topic, getPreciseBacklog, false);
       }
   
       default TopicStats getStats(String topic) throws PulsarAdminException {
           return getStats(topic, false, false);
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org