cbornet opened a new pull request #12699:
URL: https://github.com/apache/pulsar/pull/12699
### Motivation
PR #6471 introduced the possibility to set auto topic creation settings at
the namespace level
PR #6685 is a fix to take into account the auto topic creation setting when
creating a subscription
but it uses the broker configuration and doesn't see the namespace level
setting that was introduced in #6471
### Modifications
This fix uses the method that fetches config overrides in ZK instead of
the one from the broker configuration.
This way the method of the pulsar-admin uses the value set for the
namespace for auto-topic-creation
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
* Undo the changes in `PersistentTopicsBase.java` and the tests won't pass
anymore
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API: (yes / no) no
- The schema: (yes / no / don't know) no
- The default values of configurations: (yes / no) no
- The wire protocol: (yes / no) no
- The rest endpoints: (yes / no) no
- The admin cli options: (yes / no) no
- Anything that affects deployment: (yes / no / don't know) no
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
- [x] `no-need-doc`
It's a fix
- [ ] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
