Technoboy- commented on a change in pull request #12818:
URL: https://github.com/apache/pulsar/pull/12818#discussion_r749886018



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
##########
@@ -77,6 +77,7 @@
     private int newEntriesCheckDelayInMillis = 10;
     private Clock clock = Clock.systemUTC();
     private ManagedLedgerInterceptor managedLedgerInterceptor;
+    private Map<String, String> topicMetadata;

Review comment:
       Yes,we may don't need to add this field. 
   Before, I store this metadata to the ledger properties in 
ledger#openLedgerComplete. But consideration of atomic, add this field.  We 
will discuss this later. This pr will take some time to be merged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to