liangyepianzhou commented on a change in pull request #12700:
URL: https://github.com/apache/pulsar/pull/12700#discussion_r753672068
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java
##########
@@ -303,13 +303,12 @@ public void addFailed(ManagedLedgerException exception,
Object ctx) {
@Override
public void run() {
try {
- while (lastConfirmedEntry.compareTo(currentLoadPosition) > 0) {
- if (((ManagedCursorImpl) cursor).isClosed()) {
- log.warn("[{}] MLPendingAckStore cursor have been
closed, close replay thread.",
- cursor.getManagedLedger().getName());
- return;
- }
- fillEntryQueueCallback.fillQueue();
+ if (((ManagedCursorImpl) cursor).isClosed()) {
Review comment:
I think isClosed should be the basic function of ManagedCursor, so it is
suitable to add an interface here. Thanks for your reminder, I will add this
right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
