[GitHub] [pulsar] gaoran10 commented on a change in pull request #12919: [Broker] Change create topic return error to Status.BAD_REQUEST

[GitBox]

gaoran10 commented on a change in pull request #12919:
URL: https://github.com/apache/pulsar/pull/12919#discussion_r754273716



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -250,7 +250,7 @@ protected void validateAdminAndClientPermission() {
     protected void validateCreateTopic(TopicName topicName) {
         if (isTransactionInternalName(topicName)) {

Review comment:
       The topic `TRANSACTION_COORDINATOR_ASSIGN` could be created by users, 
right?

##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -250,7 +250,7 @@ protected void validateAdminAndClientPermission() {
     protected void validateCreateTopic(TopicName topicName) {
         if (isTransactionInternalName(topicName)) {
             log.warn("Try to create a topic in the system topic format! {}", 
topicName);
-            throw new RestException(Status.CONFLICT, "Cannot create topic in 
system topic format!");
+            throw new RestException(Status.BAD_REQUEST, "Cannot create topic 
in system topic format!");

Review comment:
       Could we list the system topics here? Users could know which are system 
topics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org