bharanic-dev commented on a change in pull request #12930:
URL: https://github.com/apache/pulsar/pull/12930#discussion_r758843611
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -1434,7 +1434,7 @@ protected void internalDeleteSubscription(AsyncResponse
asyncResponse, String su
internalDeleteSubscriptionForNonPartitionedTopic(asyncResponse,
subName, authoritative);
} else {
getPartitionedTopicMetadataAsync(topicName,
- authoritative, false).thenAccept(partitionMetadata -> {
+ authoritative, false).thenAcceptAsync(partitionMetadata ->
{
Review comment:
@Jason918 I don't understand how making
`internalDeleteSubscriptionForNonPartitionedTopic` return CompletableFuture
helps with solving the deadlock issue? The real issue here is the blocking
`thenAccept` call in the metadata store callback thread. The lambda for
`thenAccept` will get executed in the callback thread, but that does not happen
due to the blocking `thenAccept`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
