lhotari commented on pull request #12973:
URL: https://github.com/apache/pulsar/pull/12973#issuecomment-985271166
> @lhotari I am just using the github Web UI. In FunctionCommon.java is it
all that you added was a try / finally that wraps the the existing code in
getClassLoaderFromPackage method?
@jerrypeng Now I see what you mean. Yes the diff is pretty hard to read.
Yes, I wrapped with another try catch where the finally block is
```
} finally {
if (!keepJarClassLoader) {
closeClassLoader(jarClassLoader);
}
if (!keepNarClassLoader) {
closeClassLoader(narClassLoader);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
