michaeljmarshall commented on a change in pull request #12993:
URL: https://github.com/apache/pulsar/pull/12993#discussion_r765868408
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -1678,7 +1678,6 @@ public ManagedLedgerInterceptor
getManagedLedgerInterceptor() {
void clearPendingAddEntries(ManagedLedgerException e) {
while (!pendingAddEntries.isEmpty()) {
OpAddEntry op = pendingAddEntries.poll();
- op.close();
Review comment:
@codelipenghui - okay. My concern was that if we call
`clearPendingEntries` before the BK callback completes, we would want the state
to be closed so that the callback doesn't run further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
