[GitHub] [pulsar-client-go] zzzming commented on pull request #678: [Issue 513] Correct apparent logic error in batchContainer's hasSpace() method

[GitBox]

zzzming commented on pull request #678:
URL: https://github.com/apache/pulsar-client-go/pull/678#issuecomment-991337168


   We should use this 
   ```
   bc.numMessages+1 <= bc.maxMessages 
   ```
   
   Because this will accommodate an individual message when batch is disabled. 
Currently this configuration fails at [unable to add message to batch]
   ```
   pulsar.ProducerOptions{
                Topic:               topicName,
                DisableBatching:     true,
                BatchingMaxMessages: 1,
                BatchingMaxSize:     1,
        })
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org