yuruguo commented on a change in pull request #13157:
URL: https://github.com/apache/pulsar/pull/13157#discussion_r770186142



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
##########
@@ -122,7 +122,7 @@
     @Path("/{property}/{cluster}/{namespace}/destinations")
     @ApiOperation(hidden = true, value = "Get the list of all the topics under 
a certain namespace.",
             response = String.class, responseContainer = "Set")
-    @ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have 
admin permission"),
+    @ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have 
admin or consume permission on namespace"),

Review comment:
       @gaoran10 @michaeljmarshall Thanks for you suggestion :)
   This is a correction of known inaccurate annonations, not limited to 
`namespace polocies` operation, including: `getTopics`, 
`clearNamespaceBundleBacklog`, `unsubscribeNamespace`, etc. so perhaps `Don't 
have admin or operate permission on the namespace` is more general, what do you 
think?
   **NOTE**:`getTopics`, `clearNamespaceBundleBacklog` and 
`unsubscribeNamespace` require `consume` permission on the namespace to allow 
execution in the default authorization implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to