codelipenghui commented on a change in pull request #13543:
URL: https://github.com/apache/pulsar/pull/13543#discussion_r776185268
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ResourceGroupsBase.java
##########
@@ -63,10 +63,18 @@ protected void internalUpdateResourceGroup(String rgName,
ResourceGroup rgConfig
/*
* assuming read-modify-write
*/
-
resourceGroup.setPublishRateInMsgs(rgConfig.getPublishRateInMsgs());
-
resourceGroup.setPublishRateInBytes(rgConfig.getPublishRateInBytes());
-
resourceGroup.setDispatchRateInMsgs(rgConfig.getDispatchRateInMsgs());
-
resourceGroup.setDispatchRateInBytes(rgConfig.getDispatchRateInBytes());
+ if (rgConfig.getPublishRateInMsgs() != -1) {
Review comment:
What does `-1` means here? do not have a limit for publish rate? or `0`
means no limit for publish rate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
