michaeljmarshall commented on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-1004371158
> Makes sense to me. > > @michaeljmarshall ? @eolivelli - did you see my above comment https://github.com/apache/pulsar/pull/13245#pullrequestreview-829587801? I am opposed to this change because it makes the broker send a response to a client request that is known to be timed out. The broker knows this because the client completed the `producerFuture` by sending a `CloseProducer` command before the producer was created. The net effect of this change is that the client will log a meaningless error message for every timeout out producer. In my opinion, the core contract in this `ServerCnx` file is that the code that completes the `producerFuture` must also determine whether to send a response to the client. This change removes that contract and technically introduces a chance for the broker to respond to the same client request multiple times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
