lordcheng10 commented on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318
> @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have you tested the usage of `dynamic`? (I see that we use it elsewhere in the modified file, but I don't see how it is working.) Once we make sure that it works as expected, I'll merge this. 1. pulsar will find the field with dynamic = true through reflection： https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2365-L2374 2. When we update the configuration on zk through the command, the listening callback will be triggered： https://github.com/apache/pulsar/blob/8a0cfacd099544055cb6a5883f20c152a75d1165/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2067-L2082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
