[pulsar-manager] branch master updated: Fix for Sidebar items not visible to admin and superadmin (#435)

[guangning]

This is an automated email from the ASF dual-hosted git repository.

guangning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git


The following commit(s) were added to refs/heads/master by this push:
     new 73e4ae3  Fix for Sidebar items not visible to admin and superadmin 
(#435)
73e4ae3 is described below

commit 73e4ae37cdab1d8f1f6c08fd5aaca91c612687b6
Author: Sourabh Agrawal <sourabh.agraw...@nutanix.com>
AuthorDate: Thu Jan 13 20:07:34 2022 +0530

    Fix for Sidebar items not visible to admin and superadmin (#435)
    
    ### Motivation
    
    
    *All newly added sidebar items (Roles,Users etc)  are not visible to 
superadmin. Also when admin user login, only Token tab is visible to them.*
    
    ### Modifications
    
    *Added a new method isAccessbile in SidebarItem.vue. It compares roles 
which are set in Item.metadata.roles with logged-in user role, based on which 
the item is either visible or hidden for user*
    
    ### Verifying this change
    
    - [x] Make sure that the change passes the `./gradlew build` checks.
---
 .../src/views/layout/components/Sidebar/SidebarItem.vue  | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/front-end/src/views/layout/components/Sidebar/SidebarItem.vue 
b/front-end/src/views/layout/components/Sidebar/SidebarItem.vue
index 7815577..328cf8a 100644
--- a/front-end/src/views/layout/components/Sidebar/SidebarItem.vue
+++ b/front-end/src/views/layout/components/Sidebar/SidebarItem.vue
@@ -29,7 +29,7 @@
         <item v-if="item.meta" :icon="item.meta.icon" 
:title="generateTitle(item.meta.title)" />
       </template>
 
-      <template v-for="child in item.children" v-if="!child.hidden">
+      <template v-for="child in item.children" v-if="isAccessible(child)">
         <sidebar-item
           v-if="child.children&&child.children.length>0"
           :is-nest="true"
@@ -56,7 +56,7 @@ import { isExternal } from '@/utils'
 import Item from './Item'
 import AppLink from './Link'
 import FixiOSBug from './FixiOSBug'
-
+import store from '@/store'
 export default {
   name: 'SidebarItem',
   components: { Item, AppLink },
@@ -81,10 +81,13 @@ export default {
       onlyOneChild: null
     }
   },
+  created() {
+    this.roles = store.getters && store.getters.roles
+  },
   methods: {
     hasOneShowingChild(children, parent) {
       const showingChildren = children.filter(item => {
-        if (item.hidden) {
+        if (!this.isAccessible(item)) {
           return false
         } else {
           // Temp set(will be used if only has one showing child)
@@ -115,6 +118,13 @@ export default {
     isExternalLink(routePath) {
       return isExternal(routePath)
     },
+    isAccessible(item) {
+      const accessibleItemList = item.meta.roles.filter(i => {
+        if (this.roles.includes(i)) { return true } else { return false }
+      })
+      if (accessibleItemList.length > 0) { return true }
+      return false
+    },
     generateTitle
   }
 }