[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12818: PIP 110: Support Topic metadata - PART-1 create topic with properties

[GitBox]

BewareMyPower commented on a change in pull request #12818:
URL: https://github.com/apache/pulsar/pull/12818#discussion_r787447327



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -225,17 +225,17 @@ public void createPartitionedTopic(
             @PathParam("namespace") String namespace,
             @ApiParam(value = "Specify topic name", required = true)
             @PathParam("topic") @Encoded String encodedTopic,
-            @ApiParam(value = "The number of partitions for the topic",
-                    required = true, type = "int", defaultValue = "0")
-                    int numPartitions,
+            @ApiParam(value = "The metadata for the topic",

Review comment:
       @codelipenghui It looks like not. I ran the following command in my 
local env:
   
   ```bash
   curl -L 
http://localhost:8080/admin/v2/persistent/public/default/xxx/partitions -X PUT 
-H 'Content-Type: application/json' -d 3
   ```
   
   We can see the partitions number was recognized correctly.
   
   
![image](https://user-images.githubusercontent.com/18204803/150090107-5b82b6a3-c5c6-4e9a-9163-53b2aa273cc3.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org