codelipenghui commented on a change in pull request #13831:
URL: https://github.com/apache/pulsar/pull/13831#discussion_r787509878
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -1489,7 +1489,7 @@ public void
deleteCompactionThreshold(@PathParam("tenant") String tenant,
notes = "A negative value disables automatic offloading")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Namespace
doesn't exist") })
- public long getOffloadThreshold(@PathParam("tenant") String tenant,
+ public Long getOffloadThreshold(@PathParam("tenant") String tenant,
Review comment:
Sorry I mean, after introduces this change, the Admin will get an NPE?
The Admin also define the return type as `long`
```
long getOffloadThreshold(String namespace) throws PulsarAdminException;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
