Jason918 commented on a change in pull request #13886:
URL: https://github.com/apache/pulsar/pull/13886#discussion_r790125383
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -1315,17 +1315,14 @@ public void getInfoFailed(ManagedLedgerException
exception, Object ctx) {
protected void internalGetPartitionedStats(AsyncResponse asyncResponse,
boolean authoritative, boolean perPartition,
boolean getPreciseBacklog,
boolean subscriptionBacklogSize,
boolean
getEarliestTimeInBacklog) {
+ CompletableFuture<Void> future;
if (topicName.isGlobal()) {
- try {
- validateGlobalNamespaceOwnership(namespaceName);
- } catch (Exception e) {
- log.error("[{}] Failed to get partitioned stats for {}",
clientAppId(), topicName, e);
- resumeAsyncResponseExceptionally(asyncResponse, e);
- return;
- }
+ future = validateGlobalNamespaceOwnershipAsync(namespaceName);
Review comment:
Exception of `validateGlobalNamespaceOwnershipAsync` is not handled
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
