[GitHub] [pulsar] Jason918 commented on a change in pull request #13538: Add publishRateLimitedTimes to topic metrics

[GitBox]

Jason918 commented on a change in pull request #13538:
URL: https://github.com/apache/pulsar/pull/13538#discussion_r790201617



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -2477,6 +2478,7 @@ public void startSendOperation(Producer producer, int 
msgSize, int numMessages)
                     
producer.getTopic().isTopicPublishRateExceeded(numMessages, msgSize);
             if (isPreciseTopicPublishRateExceeded) {
                 producer.getTopic().disableCnxAutoRead();
+                recordRateLimitMetrics(producers.values());

Review comment:
       > `producers.values().forEach(producer -> 
producer.getCnx().disableCnxAutoRead());`
   
   This line is in 
`org.apache.pulsar.broker.service.AbstractTopic#disableCnxAutoRead`,  the 
`producers` is  `AbstractTopic#producers` not `ServerCnx#producers`.
   So it contains producers in both `ServerCnx1` and `ServerCnx2`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org