nodece commented on a change in pull request #13850:
URL: https://github.com/apache/pulsar/pull/13850#discussion_r790261729
##########
File path:
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -227,15 +227,15 @@ public void accept(Notification n) {
}
// Ensure caches are invalidated before the operation is confirmed
return storeDelete(path, expectedVersion)
- .thenRun(() -> {
+ .thenRunAsync(() -> {
Review comment:
You cannot use the executor to execute this, this callback thread is
sometimes executed in the executor thread:
https://github.com/apache/pulsar/blob/master/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java#L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
