Technoboy- commented on a change in pull request #13383:
URL: https://github.com/apache/pulsar/pull/13383#discussion_r790721977
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##########
@@ -811,8 +916,15 @@ public Subscription getSubscription() {
}
private int addAndGetUnAckedMsgs(Consumer consumer, int ackedMessages) {
- subscription.addUnAckedMessages(ackedMessages);
- return UNACKED_MESSAGES_UPDATER.addAndGet(consumer, ackedMessages);
+ int unackedMsgs = 0;
+ if (Subscription.isIndividualAckMode(subType)) {
+ subscription.addUnAckedMessages(ackedMessages);
+ unackedMsgs = UNACKED_MESSAGES_UPDATER.addAndGet(consumer,
ackedMessages);
+ }
+ if (unackedMsgs < 0) {
+ log.error("unackedMsgs is : {}, ackedMessages : {}, consumer :
{}", unackedMsgs, ackedMessages, consumer);
Review comment:
Even if we throw an error, we have to do nothing at broker's side.
So add a log to track if there is an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
