Technoboy- commented on a change in pull request #13935:
URL: https://github.com/apache/pulsar/pull/13935#discussion_r791408084
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -356,6 +357,21 @@ private void reapDeadBrokerPreallocations(List<String>
aliveBrokers) {
}
}
+ @Override
+ public CompletableFuture<Set<String>> getAvailableBrokersAsync() {
+ CompletableFuture<Set<String>> getAvailableBrokersAsync = new
CompletableFuture<>();
+ brokersData.listLocks(LoadManager.LOADBALANCE_BROKERS_ROOT)
+ .whenComplete((listLocks, ex) -> {
+ if (ex != null){
+ Throwable realCause =
FutureUtil.unwrapCompletionException(ex);
+ log.warn("Error when trying to get active brokers",
realCause);
+
getAvailableBrokersAsync.complete(loadData.getBrokerData().keySet());
+ }
Review comment:
It's better to add `else` block
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##########
@@ -303,6 +305,21 @@ public void disableBroker() throws Exception {
return new
HashSet<>(loadReports.listLocks(LOADBALANCE_BROKERS_ROOT).join());
}
+ @Override
+ public CompletableFuture<Set<String>> getAvailableBrokersAsync() {
+ CompletableFuture<Set<String>> getAvailableBrokersAsync = new
CompletableFuture<>();
Review comment:
getAvailableBrokersAsync -> future
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -356,6 +357,21 @@ private void reapDeadBrokerPreallocations(List<String>
aliveBrokers) {
}
}
+ @Override
+ public CompletableFuture<Set<String>> getAvailableBrokersAsync() {
+ CompletableFuture<Set<String>> getAvailableBrokersAsync = new
CompletableFuture<>();
+ brokersData.listLocks(LoadManager.LOADBALANCE_BROKERS_ROOT)
+ .whenComplete((listLocks, ex) -> {
+ if (ex != null){
+ Throwable realCause =
FutureUtil.unwrapCompletionException(ex);
+ log.warn("Error when trying to get active brokers",
realCause);
+
getAvailableBrokersAsync.complete(loadData.getBrokerData().keySet());
+ }
Review comment:
getAvailableBrokersAsync -> future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
