congbobo184 commented on a change in pull request #13938:
URL: https://github.com/apache/pulsar/pull/13938#discussion_r791769519
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2342,15 +2342,13 @@ protected SchemaCompatibilityStrategy
internalGetSchemaCompatibilityStrategy() {
validateNamespacePolicyOperation(namespaceName,
PolicyName.SCHEMA_COMPATIBILITY_STRATEGY,
PolicyOperation.READ);
Policies policies = getNamespacePolicies(namespaceName);
+
SchemaCompatibilityStrategy schemaCompatibilityStrategy =
policies.schema_compatibility_strategy;
- if (schemaCompatibilityStrategy ==
SchemaCompatibilityStrategy.UNDEFINED) {
- schemaCompatibilityStrategy =
pulsar().getConfig().getSchemaCompatibilityStrategy();
- if (schemaCompatibilityStrategy ==
SchemaCompatibilityStrategy.UNDEFINED) {
- schemaCompatibilityStrategy = SchemaCompatibilityStrategy
-
.fromAutoUpdatePolicy(policies.schema_auto_update_compatibility_strategy);
- }
+ if
(!SchemaCompatibilityStrategy.isUndefined(schemaCompatibilityStrategy)) {
+ return schemaCompatibilityStrategy;
}
- return schemaCompatibilityStrategy;
+
+ return
SchemaCompatibilityStrategy.fromAutoUpdatePolicy(policies.schema_auto_update_compatibility_strategy);
Review comment:
may we don't return policies.schema_auto_update_compatibility_strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
