pgier opened a new pull request #719:
URL: https://github.com/apache/pulsar-client-go/pull/719
This upgrades the dependency from the oauth2 module to 99designs/keyring to
remove the compiler warnings on macos.
Fixes #679
### Motivation
*Explain here the context, and why you're making that change. What is the
problem you're trying to solve.*
Building on recent versions of OSX/MacOS outputs the following compiler
warnings.
```
cgo-gcc-prolog:81:11: warning: 'SecKeychainCreate' is deprecated: first
deprecated in macOS 12.0 - Custom keychain management is no longer supported
[-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:301:10:
note: 'SecKeychainCreate' has been explicitly marked deprecated here
cgo-gcc-prolog:139:11: warning: 'SecKeychainLock' is deprecated: first
deprecated in macOS 12.0 - Custom keychain management is no longer supported
[-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:357:10:
note: 'SecKeychainLock' has been explicitly marked deprecated here
cgo-gcc-prolog:159:11: warning: 'SecKeychainOpen' is deprecated: first
deprecated in macOS 12.0 - Custom keychain management is no longer supported
[-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:287:10:
note: 'SecKeychainOpen' has been explicitly marked deprecated here
cgo-gcc-prolog:183:11: warning: 'SecKeychainUnlock' is deprecated: first
deprecated in macOS 12.0 - Custom keychain management is no longer supported
[-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:347:10:
note: 'SecKeychainUnlock' has been explicitly marked deprecated here
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is
deprecated: first deprecated in macOS 10.15 - No longer supported
[-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10:
note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked
deprecated here
```
### Modifications
The warnings are coming from the dependency on 99designs/keyring. This PR
upgrades to the latest master of that project in order to remove the compiler
warnings, and avoid some potential build failures as described in #679
### Verifying this change
- [ X ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *(please describe
tests)*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
