lhotari commented on a change in pull request #13993:
URL: https://github.com/apache/pulsar/pull/13993#discussion_r794650360



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/Backoff.java
##########
@@ -22,29 +22,59 @@
 import java.time.Clock;
 import java.util.Random;
 import java.util.concurrent.TimeUnit;
-import lombok.Data;
+import lombok.Getter;
 
-// All variables are in TimeUnit millis by default
-@Data

Review comment:
       I guess `@Data` should be replaced with `@ToString @EqualsAndHashCode` 
if the intention is to remove setters. `@Value` would be the correct solution 
if `Backoff` would be fully immutable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to