jai1 commented on a change in pull request #1124: Support Pulsar proxy from
C++/Python client library
URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164505677
##########
File path: pulsar-client-cpp/lib/Url.h
##########
@@ -41,6 +41,8 @@ class Url {
const std::string& parameter() const;
friend std::ostream& operator<<(std::ostream& os, const Url& obj);
+ std::string hostPort() const;
Review comment:
How about returning const reference:-
const std::string& hostPort() const;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
